Use react-query for data fetches #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-336--dev-tinlake.netlify.app |
jpangelle
reviewed
Aug 25, 2021
| @@ -27,7 +28,7 @@ const PoolsMetrics: React.FC<Props> = (props: Props) => { | |||
|
|
|||
| const maxPoolValue = Math.max.apply( | |||
| Math, | |||
| poolsDailyData.map((o) => { | |||
| dailyTVL.map((o) => { | |||
There was a problem hiding this comment.
we needa change these one letter variable names soon 🙈
jpangelle
reviewed
Aug 25, 2021
| @@ -30,15 +32,53 @@ interface Props { | |||
|
|
|||
| export type Card = 'home' | 'collect' | 'order' | 'invest' | 'redeem' | |||
|
|
|||
| function useTrancheData(tinlake: ITinlake, tranche: 'senior' | 'junior', address?: string | null) { | |||
There was a problem hiding this comment.
maybe we move this to the hooks folder?
There was a problem hiding this comment.
Yeah, probably. Or we can combine it with the epoch data hook and make it one multicall to avoid having a bunch of requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes most ducks that were used for data fetching and replace with hook that use react-query to fetch the data. The
loansanduserRewardsducks are still todo, but will leave those for a later time.Closes #344