CollectionDataFeed: Minor changes #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q1-easy
lemunozm
force-pushed
the
feature/collection-data-result
branch
from
7eb31fc
to
f85eddb
Compare
hieronx
reviewed
May 17, 2023
4 tasks
hieronx
approved these changes
May 17, 2023
thea-leake
approved these changes
May 17, 2023
| collection | ||
| .get_mut(data_id) | ||
| .map(|value| *value = Self::get(data_id)) | ||
| if let Some(value) = collection.get_mut(data_id) { |
There was a problem hiding this comment.
I'm wondering if It might read a little cleaner flattened with match, though feel free to disregard if not :)
match (collection.get_mut(data_id), Self::get(data_id)) {
(Some(value), Ok(new_value)) => *value = new_value,
_ => ()
}
There was a problem hiding this comment.
I really like your suggestion here @thea-leake!! I had the auto-merge enabled, but I'll update this in the next PRs. Thanks! 🙌🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor changes over
collection-data-feedto prepare it for the OracleValuation feature.Changes and Descriptions
Resultinstead of Option.MockDataCollectionwith user callback.