Drop PricingAdmin role
#1399
Drop PricingAdmin role
#1399
Conversation
| @@ -35,7 +35,6 @@ use sp_std::{ | |||
| pub enum PoolRole<TrancheId = [u8; 16], Moment = u64> { | |||
| PoolAdmin, | |||
| Borrower, | |||
| PricingAdmin, | |||
There was a problem hiding this comment.
I think this is not so easy 😖, removing that enum variant will give other internal memory representations for the next variants, so I think we need several migrations in different pallets to get this to work fine.
If this is not viable, maybe marking it as deprecated can be enough, to get a warning if somebody uses it.
There was a problem hiding this comment.
Thanks for the insight! I will undo this whole PR and just deprecate that variant
There was a problem hiding this comment.
Or we can also remove it but add #[codec(index = x)] marks on each variant to ensure they remain with the same encoding representation?
There was a problem hiding this comment.
We store the permissions as bit fields though (see the block of code just after this enum). So I don't think we're ever using the enum variant index in storage.
There was a problem hiding this comment.
If this is the case and we never store the enum directly, then we are safe 🙌🏻
There was a problem hiding this comment.
If not, #[codec(index = x)] is a good idea I think 👍🏻
There was a problem hiding this comment.
According to Subscan, we have three accounts with PricingAdmin role on Altair:
- https://altair.subscan.io/extrinsic/1369696-2?event=1369696-3
- https://altair.subscan.io/extrinsic/1349858-2?event=1349858-3
- https://altair.subscan.io/extrinsic/1369696-2?event=1369696-7
Centrifuge is fine as no permissions have been added so far.
As a consequence, we need to write a migration, removing this storage entry.
Closes #1398