Fix RustDocs & AlwaysPass codecov patch check #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
=======================================
Coverage 47.34% 47.34%
=======================================
Files 176 176
Lines 13305 13305
=======================================
Hits 6299 6299
Misses 7006 7006 ☔ View full report in Codecov by Sentry. |
|
How can we have the |
|
I'm absolutely puzzled. It's complaining about code lines from 2 years ago. |
|
#1871 should fix it... |
|
We'll have to wait for William to be back but it's not urgent, every time this PR gets updated with the latest from main the docs are automatically deployed by the workflow as this is treated as a special branch. |
gpmayorga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://kflabs.slack.com/archives/C04GJQAM9P0/p1718188938855999
Fix docs deployments, broken for about a month due to a GHA module upgrade