Liquidity pools: Add UTs to for update_token_price()
#1890
Conversation
lemunozm
added
I4-tests
| /// A trait that can be used to retrieve the current price for a currency | ||
| pub struct CurrencyPair<CurrencyId> { | ||
| pub base: CurrencyId, | ||
| pub quote: CurrencyId, | ||
| } | ||
|
|
||
| pub struct PriceValue<CurrencyId, Rate, Moment> { | ||
| pub pair: CurrencyPair<CurrencyId>, | ||
| pub price: Rate, | ||
| pub last_updated: Moment, | ||
| } | ||
|
|
||
| pub trait CurrencyPrice<CurrencyId> { | ||
| type Rate; | ||
| type Moment; | ||
|
|
||
| /// Retrieve the latest price of `base` currency, denominated in the `quote` | ||
| /// currency If `quote` currency is not passed, then the default `quote` | ||
| /// currency is used (when possible) | ||
| fn get_latest( | ||
| base: CurrencyId, | ||
| quote: Option<CurrencyId>, | ||
| ) -> Option<PriceValue<CurrencyId, Self::Rate, Self::Moment>>; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not used, but if it's intended to be used very soon, I can revert this. Otherwise, I would left removed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
+ Coverage 47.38% 47.49% +0.11%
==========================================
Files 176 176
Lines 13305 13304 -1
==========================================
+ Hits 6304 6319 +15
+ Misses 7001 6985 -16 ☔ View full report in Codecov by Sentry. |
| let price = prices.get(tranche_index).cloned()?; | ||
|
|
||
| Some(PriceValue { |
There was a problem hiding this comment.
@hieronx you added this change. Why did you wanted to have the TrancheCurrency and the PoolCurrency named here?
There was a problem hiding this comment.
I don't fully remember. I think we just set up the PriceValue for some other purpose, and then used that here.
| @@ -426,7 +426,7 @@ pub mod pallet { | |||
| // TODO(future): Once we diverge from 1-to-1 conversions for foreign and pool | |||
| // currencies, this price must be first converted into the currency_id and then | |||
| // re-denominated to 18 decimals (i.e. `Ratio` precision) | |||
| let price_value = T::TrancheTokenPrice::get(pool_id, tranche_id) | |||
| let (price, computed_at) = T::TrancheTokenPrice::get_price(pool_id, tranche_id) | |||
There was a problem hiding this comment.
@lemunozm can we in the same run also close this todo and computed the conversion?
There was a problem hiding this comment.
I'm not sure if it's super straightforward. Do we need to add the order-book dependency to know the market price used for foreign/pool currencies?
There was a problem hiding this comment.
I agree it isn't. But we are not only touching the UTs here but also chaning the return types, naming etc. Then we could also close the todo IMO.
There was a problem hiding this comment.
Done here: 15424a8 @mustermeiszer
Description
UTs for
update_token_price()NOTE: It's not directly related to LPv2
Changes and Descriptions