Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch message support #291

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Batch message support #291

wants to merge 59 commits into from

Conversation

hieronx
Copy link
Contributor

@hieronx hieronx commented Apr 26, 2024

No description provided.

@hieronx hieronx changed the base branch from im-renamings to main May 3, 2024 13:45
@hieronx hieronx marked this pull request as ready for review May 3, 2024 13:46
Copy link
Contributor

@AStox AStox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's being implicitly tested since it's in BaseTest now, but I think it would be nice to add a couple explicit unit tests to Messages.t.sol for batched messages

src/gateway/Gateway.sol Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jun 6, 2024

Coverage after merging batch into main will be

90.29%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Auth.sol100%100%100%100%
   CentrifugeRouter.sol18.42%12.50%25%18.18%16, 27–29, 34–35, 35, 35–38, 43–44, 44, 44–47, 53, 60, 65–66, 66, 66–67
   ERC7540Vault.sol85.21%78.57%92.86%82.56%117, 123, 162–164, 186–188, 59–65, 67–68, 88
   Escrow.sol100%100%100%100%
   InvestmentManager.sol90.65%88.04%86.36%92.97%134, 248, 257, 301, 330, 352, 384, 388–389, 511, 554–557, 566–569, 569, 569, 60–61, 63–64
   PoolManager.sol95.38%99.06%76.92%95.91%203, 206, 66–69, 71–72
   Root.sol92.11%88.89%92.86%93.18%124, 129, 149–150, 38
src/admin
   Guardian.sol66.67%50%77.78%63.64%23–25, 29, 29, 63
src/factories
   ERC7540VaultFactory.sol100%100%100%100%
   RestrictionManagerFactory.sol66.67%100%50%70%23, 25–26
   TrancheTokenFactory.sol100%100%100%100%
   TransferProxyFactory.sol85.71%100%75%87.50%38
src/gateway
   Gateway.sol90.91%100%83.33%86.11%41–43, 45–46
src/gateway/routers
   Aggregator.sol89.47%80.77%83.33%95.45%108–109, 113, 152, 155–156, 159, 167, 40, 42–43, 49, 51, 99
src/gateway/routers/axelar
   Forwarder.sol80%100%75%75%38, 40–41
   Router.sol84.21%100%66.67%75%34–35
src/token
   ERC20.sol97.62%95%100%98.63%201, 73–74
   RestrictionManager.sol94.83%100%66.67%100%
   Tranche.sol77.14%62.50%72.73%87.50%55, 64, 73, 83, 93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants