Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM Reorder messages #333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DNM Reorder messages #333

wants to merge 1 commit into from

Conversation

hieronx
Copy link
Contributor

@hieronx hieronx commented Jun 25, 2024

No description provided.

@hieronx hieronx changed the title Reorder messages DNM Reorder messages Jun 25, 2024
Copy link

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four message names were not updated

/// 20 - Unfreeze tranche tokens
Unfreeze,
/// --- Investment Manager ---
/// 21 - Increase an investment order by a given amount
IncreaseInvestOrder,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IncreaseInvestOrder,
RequestDeposit,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, good catch, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wischli changed to DepositRequest (and likewise for RedeemRequest) to be more consistent with the other messages

src/libraries/MessagesLib.sol Outdated Show resolved Hide resolved
src/libraries/MessagesLib.sol Outdated Show resolved Hide resolved
@hieronx hieronx changed the base branch from gg/feat/automate-gas-payments to refactor-tt July 1, 2024 07:46
@hieronx hieronx changed the base branch from refactor-tt to main July 2, 2024 10:48
Copy link

github-actions bot commented Jul 2, 2024

Coverage after merging reorder into main will be

87.68%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Auth.sol100%100%100%100%
   CentrifugeRouter.sol60.16%50%70%62.32%101–102, 102, 102–103, 105, 107–109, 116, 131, 152, 152, 162, 166, 176, 181, 183–184, 184–185, 187–188, 188, 192–193, 193, 195, 195, 201, 206, 208, 225, 34–36, 38–39, 43, 50, 50, 73, 86
   ERC7540Vault.sol91.41%72.73%95.35%93.88%100, 128, 176–178, 203–205, 231–233, 245
   Escrow.sol75%100%66.67%71.43%29–30
   InvestmentManager.sol88.47%83.70%81.82%92.43%112, 230, 239, 256, 283, 312, 334, 366, 370–371, 38–39, 41–42, 490, 493, 524, 536–539, 548–551, 551, 551, 585–586
   PoolManager.sol90.41%91.51%69.23%93.13%186, 188, 188, 188–189, 191, 247, 346, 346, 346–347, 347, 347–348, 371, 52–54, 56–57
   Root.sol94.74%88.89%92.86%97.73%120, 125, 34
src/admin
   Guardian.sol66.67%50%77.78%63.64%21–23, 27, 27, 61
src/factories
   ERC7540VaultFactory.sol71.43%100%66.67%72.73%31, 33–34
   TrancheFactory.sol100%100%100%100%
   TransferProxyFactory.sol100%100%100%100%
src/gateway
   GasService.sol0%0%0%0%25–29, 31–32, 37, 37, 37–38, 38, 38–40, 45, 45, 45–47, 52, 57–58, 60, 60, 60–61, 63, 66, 71
   Gateway.sol89.11%82.56%82.35%93.51%133, 133, 133–134, 136, 169–170, 174, 234, 237–238, 241, 249, 285, 291, 308, 317, 62–65, 67–68, 83, 85
src/gateway/adapters/axelar
   Adapter.sol50%80%33.33%37.50%49–51, 53–54, 59, 59, 59–61, 91, 99
   Forwarder.sol80%100%75%75%38, 40–41
src/token
   ERC20.sol97.17%94.12%100%98.33%170, 69–70
   RestrictionManager.sol96.39%96.43%91.67%97.67%108–109
   Tranche.sol78.08%54.55%83.33%90.91%101–102, 117–118, 129, 135, 141, 141, 141–142, 147, 31, 91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants