-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM Reorder messages #333
base: main
Are you sure you want to change the base?
DNM Reorder messages #333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Four message names were not updated
src/libraries/MessagesLib.sol
Outdated
/// 20 - Unfreeze tranche tokens | ||
Unfreeze, | ||
/// --- Investment Manager --- | ||
/// 21 - Increase an investment order by a given amount | ||
IncreaseInvestOrder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IncreaseInvestOrder, | |
RequestDeposit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wischli changed to DepositRequest
(and likewise for RedeemRequest
) to be more consistent with the other messages
Coverage after merging reorder into main will be
Coverage Report |
No description provided.