Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added Obj-C support check in generated bundle header files #999

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: Added Obj-C support check in generated bundle header files #999

merged 2 commits into from
Apr 8, 2024

Conversation

krypt-lx
Copy link
Contributor

@krypt-lx krypt-lx commented Apr 8, 2024

This commit adds check for presence of ObjC support in currently used compiler. If not, skips SWIFTPM_MODULE_BUNDLE macros altogether.

fixes #998

@krypt-lx krypt-lx changed the title Added Obj-C support check in generated bundle header files fix: Added Obj-C support check in generated bundle header files Apr 8, 2024
@cgrindel cgrindel enabled auto-merge (squash) April 8, 2024 19:16
@cgrindel cgrindel merged commit 1029c2d into cgrindel:main Apr 8, 2024
35 checks passed
renovate bot added a commit to bazel-contrib/rules_bazel_integration_test that referenced this pull request Apr 11, 2024
…#302)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| rules_swift_package_manager | bazel_dep | patch | `0.29.1` -> `0.29.2`
|
|
[rules_swift_package_manager](https://github.com/cgrindel/rules_swift_package_manager)
| http_archive | patch | `v0.29.1` -> `v0.29.2` |

---

### Release Notes

<details>
<summary>cgrindel/rules_swift_package_manager
(rules_swift_package_manager)</summary>

###
[`v0.29.2`](https://github.com/cgrindel/rules_swift_package_manager/releases/tag/v0.29.2)

[Compare
Source](https://github.com/cgrindel/rules_swift_package_manager/compare/v0.29.1...v0.29.2)

#### What's Changed

- chore: update README.md for v0.29.1 by
[@&#8203;cgrindel-app-token-generator](https://github.com/cgrindel-app-token-generator)
in
[cgrindel/rules_swift_package_manager#979
- chore(deps): update dependency rules_swift to v1.17.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#973
- chore(deps): update dependency cgrindel_bazel_starlib to v0.20.2 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#974
- chore(deps): update dependency quick/quick to from: "7.5.0" by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#980
- chore(deps): update dependency marmelroy/phonenumberkit to from:
"3.7.10" by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#981
- feat: Support netrc authentication by
[@&#8203;jflan-dd](https://github.com/jflan-dd) in
[cgrindel/rules_swift_package_manager#982
- chore(deps): update dependency sdwebimage/sdwebimageswiftui to from:
"3.0.2" by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#986
- chore(deps): update dependency rules_apple to v3.4.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#988
- fix(deps): update module github.com/stretchr/testify to v1.9.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#943
- chore(deps): update dependency apple_support to v1.15.1 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#989
- chore(deps): update dependency google/googlesignin-ios to from:
"7.1.0" by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#984
- chore(deps): update dependency bazel_gazelle to v0.36.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#990
- chore(deps): update dependency gazelle to v0.36.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#991
- chore(deps): update dependency rules_xcodeproj to v2 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#993
- chore(deps): update dependency airbnb/lottie-spm to from: "4.4.2" by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#994
- fix: Added Obj-C support check in generated bundle header files by
[@&#8203;krypt-lx](https://github.com/krypt-lx) in
[cgrindel/rules_swift_package_manager#999
- chore(deps): update dependency build_bazel_rules_swift to v1.18.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#995
- chore(deps): update dependency firebase/firebase-ios-sdk to from:
"10.23.1" by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#948
- chore(deps): update dependency rules_apple to v3.5.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#996
- chore(deps): update dependency rules_swift to v1.18.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://github.com/cgrindel-self-hosted-renovate)
in
[cgrindel/rules_swift_package_manager#997

#### New Contributors

- [@&#8203;jflan-dd](https://github.com/jflan-dd) made their first
contribution in
[cgrindel/rules_swift_package_manager#982
- [@&#8203;krypt-lx](https://github.com/krypt-lx) made their first
contribution in
[cgrindel/rules_swift_package_manager#999

**Full Changelog**:
cgrindel/rules_swift_package_manager@v0.29.1...v0.29.2

#### Bazel Module Snippet

```python
bazel_dep(name = "rules_swift_package_manager", version = "0.29.2")
```

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_swift_package_manager",
    sha256 = "b60a02e75b1cffce6951a992b9d389a51cbbd98f190e507b625a8eeb70b4def5",
    urls = [
        "https://github.com/cgrindel/rules_swift_package_manager/releases/download/v0.29.2/rules_swift_package_manager.v0.29.2.tar.gz",
    ],
)

load("@&#8203;rules_swift_package_manager//:deps.bzl", "swift_bazel_dependencies")

swift_bazel_dependencies()

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

### MARK: - Gazelle
### gazelle:repo bazel_gazelle

load("@&#8203;bazel_gazelle//:deps.bzl", "gazelle_dependencies")
load("@&#8203;rules_swift_package_manager//:go_deps.bzl", "swift_bazel_go_dependencies")
load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

### Declare Go dependencies before calling go_rules_dependencies.
swift_bazel_go_dependencies()

go_rules_dependencies()

go_register_toolchains(version = "1.21.1")

gazelle_dependencies()

### MARK: - Swift Toolchain

http_archive(
    name = "build_bazel_rules_swift",

### Populate with your preferred release 
### https://github.com/bazelbuild/rules_swift/releases
)

load(
    "@&#8203;build_bazel_rules_swift//swift:repositories.bzl",
    "swift_rules_dependencies",
)
load("//:swift_deps.bzl", "swift_dependencies")

### gazelle:repository_macro swift_deps.bzl%swift_dependencies
swift_dependencies()

swift_rules_dependencies()

load(
    "@&#8203;build_bazel_rules_swift//swift:extras.bzl",
    "swift_rules_extra_dependencies",
)

swift_rules_extra_dependencies()
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/rules_bazel_integration_test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't compile Firebase (anymore)
2 participants