-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove istanbul #1549
Remove istanbul #1549
Conversation
Replace it with nyc or c8? Modern successors to Istanbul |
if we can still have coverage, that would be nice. sometimes it is useful just as a quick guide to obvious uncovered blocks, etc locally. @voxpelli is right in that we should use c8 or nyc if we do that (i prefer c8) maybe another PR though |
e291b52
to
63d6a6e
Compare
As far as I can tell the coverage doesn't seem to work at all1 and I don't see any complaints about that so I assumed that it's unused. With it not working currently I figure we remove it as non-functional and someone can add coverage back in a different PR. If it's just used as a developer tool it might be as simple as running Footnotes
|
Istanbul is deprecated and I don't think we are doing a lot with code coverage these days.