-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removes ??
for node compat
#1574
Conversation
We shipped syntax which is beyond our `engine` constraint. `??` is available in node 14 but 4.x is node 4 and above, while 5.x is node 12 and above. This just dumbs it back down to `||` for now at least. Fixes chaijs#1573
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to keep them in sync, for now, making 2 PRs will suffice. We'll figure out a better way of dealing with this overtime, perhaps.
Perhaps one way of dealing with this is to make the changes in main
, then when we release a 5.x.x
version, we should go back and backport those changes to 4.x.x
.
Hi, by when can we expect these changes to be merged and the issue to be resolved ? |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [chai](http://chaijs.com) ([source](https://github.com/chaijs/chai)) | [`^4.3.10` -> `^4.4.1`](https://renovatebot.com/diffs/npm/chai/4.4.0/4.4.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/chai/4.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/4.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.4.0/4.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.4.0/4.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chaijs/chai (chai)</summary> ### [`v4.4.1`](https://github.com/chaijs/chai/releases/tag/v4.4.1) [Compare Source](https://github.com/chaijs/chai/compare/v4.4.0...v4.4.1) #### What's Changed - fix: removes `??` for node compat by [@​43081j](https://github.com/43081j) in [chaijs/chai#1574 **Full Changelog**: chaijs/chai@v4.4.0...v4.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/compiler-explorer/compiler-explorer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
We shipped syntax which is beyond our
engine
constraint.??
is available in node 14 but 4.x is node 4 and above, while 5.x is node 12 and above.This just dumbs it back down to
||
for now at least.Fixes #1573
@koddsson @keithamus can we just catch 5.x up from 4.x when this lands? how do we deal with keeping them in sync, as 5 needs this too