Fixed bug in remove #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some overlap with #42 |
|
@escalonn the first bug fix was a copy of the code changes from your PR #42. I think the second fix will resolve the rest of the issues with the remove function. I tested it with the file issue41a_test.txt from Issue #41 and it fixed the problem. |
mhsaul
force-pushed
the
fix-remove-bug
branch
from
ede99a9
to
c832414
Compare
mhsaul
force-pushed
the
fix-remove-bug
branch
from
c832414
to
7898b67
Compare
|
Hey, I encountered the same problem and this fix worked for me perfectly. However it has not yet been merged into the master branch or the current releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug occurs when replacing a removed node. If
childconsumes all the nodes ins_center, the node is completely removed from the tree which allows its parent to become in balanced. Re-balancing will happen in lines 399-400 and cause the parent to be rotated down to be the right child of its current left child. The problem here is that if the parent contains any overlapping intervals withchild.x_center, these intervals will not be added to child, since the check for overlaps in lines 403-405 will look at the new parent (i.e. the left child of the old parent). Thus, the invariant that no node overlaps thex_centerof any of its ancestors is broken.