feat: sideEffects false

[dangreen]

closes #10284

The problem was what Rollup was applying sideEffects: false to test build for Karma, which has side effects.

NOTE: need to merge #10504 and #10525 first

[kurkle]

Isn't that the same build that would end up in cdn? If tests needs. treeshake: false, then the umd build would not be complete, right?

[dangreen]

@kurkle Yes. But here they marked as files with side effects.

[kurkle]

I committed the dist/chart.js to a test repository for a diff. This is what changes on the output with these additions:
https://github.com/kurkle/chart-test/commit/df9562b9fcdbae96c7827d7c23a6fc38d395f5ea

[dangreen]

@kurkle Sorry. Fixed. I missed that we have one file with side effects in src.

[benmccann]

Are there any TODOs we should add to remove the side effects? I'm curious if you think there are follow-ups we should do to this

[dangreen]

If you are worried about that side-effects from "core.scale.defaults" will every time in the bundle, I can calm down you: in PR with tree-shaking this problem is solved, you can test it on my test bench.

It's not true. defaults.set code will always be in the user's bundle because it is a side-effect.

Maybe we should just point to the entry in src/ or copy them from src/ to dist/ if needed

It will not help.

Is there a way that we can set the defaults in a side-effect free manner so that we don't have to include either file regardless?

I will try to make it

[dangreen]

I will try to make it

I think it doesn't make sense because this code will be in a bundle in most cases anyway.

[dangreen]

@kurkle Could you please restart CI? It has strange error.

[kurkle]

@kurkle Could you please restart CI? It has strange error.

Restarted, though it might be due to other merges. Maybe a rebase is needed.

[dangreen]

master:

"refactor: apply defaults by pure way":

[benmccann]

If you don't mind waiting a little bit, I'll send an alternative idea for review and we can decide which approach we might want to take. I'll do that in the next few hours

[benmccann]

I started on making animations optional here: #10574. After digging into the code, it looks like this won't necessarily conflict with that work, so we could probably merge this and then I can just build on top of it