Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass timestamp to ticks callback #10540

Merged
merged 3 commits into from
Aug 5, 2022
Merged

fix: pass timestamp to ticks callback #10540

merged 3 commits into from
Aug 5, 2022

Conversation

dangreen
Copy link
Collaborator

@dangreen dangreen commented Aug 1, 2022 •
edited
Loading

fixes #8884

@dangreen dangreen marked this pull request as ready for review August 1, 2022 21:55
@benmccann
Copy link
Contributor

@dangreen if you make the PR description "fixes #8884" or "closes #8884" then it will automatically close the issue when the PR is merged

@stockiNail
Copy link
Contributor

@dangreen maybe we could add a note to the doc, where ticks callback is described: https://www.chartjs.org/docs/latest/axes/labelling.html#creating-custom-tick-formats

@dangreen
Copy link
Collaborator Author

dangreen commented Aug 3, 2022

@stockiNail Done

etimberg
etimberg previously approved these changes Aug 3, 2022
View reviewed changes
kurkle
kurkle requested changes Aug 3, 2022
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added in the migration guide.

@dangreen
Copy link
Collaborator Author

dangreen commented Aug 4, 2022

@kurkle Done.

kurkle
kurkle previously approved these changes Aug 4, 2022
View reviewed changes
@kurkle kurkle added this to the Version 4.0 milestone Aug 5, 2022
@etimberg etimberg merged commit b19fc01 into chartjs:master Aug 5, 2022
@dangreen dangreen deleted the fix-8884 branch August 16, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
breaking change type: bug
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

[bug][v3.1.0] ticks.callback incorrect tickValue
6 participants
@dangreen @benmccann @stockiNail @etimberg @kurkle @LeeLenaleee