Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tooltip callbacks fallback #10567

Merged
merged 2 commits into from
Aug 18, 2022
Merged

feat: tooltip callbacks fallback #10567

merged 2 commits into from
Aug 18, 2022

Conversation

dangreen
Copy link
Collaborator

@dangreen dangreen commented Aug 5, 2022

Now, if tooltip callback returns undefined, then will be used default callback.

@dangreen dangreen marked this pull request as ready for review August 5, 2022 10:19
kurkle
kurkle reviewed Aug 7, 2022
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've not used void in the docs, should we start to and if so, for what reason?

@dangreen
Copy link
Collaborator Author

@kurkle Hi. Review please 🙏

@kurkle kurkle added this to the Version 4.0 milestone Aug 18, 2022
@kurkle kurkle merged commit ffce0f9 into chartjs:master Aug 18, 2022
@dangreen dangreen deleted the feat-tooltip-callbacks-fallback branch September 12, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dangreen @etimberg @kurkle