Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document components for bundle optimization #10569

Merged
merged 8 commits into from
Aug 23, 2022
Merged

Document components for bundle optimization #10569

merged 8 commits into from
Aug 23, 2022

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Aug 5, 2022

Continuing the work @artfulrobot started.

Several people have struggled to use the new tree shaking feature, adding to stackoverflow, issue queues etc. because of a lack of documentation.

See #8105 (comment) inviting a PR.

closes #9721

@kurkle kurkle added this to the Version 4.0 milestone Aug 5, 2022
LeeLenaleee
LeeLenaleee previously approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maby still keep the old one beneath for a quick copy paste, so people can remove the items they dont need in their code instead of needing to copy/paste every item indevidually.

If thats not the way we want to go it looks good to me

etimberg
etimberg previously approved these changes Aug 5, 2022
View reviewed changes
@etimberg
Copy link
Member

@kurkle do you want to update the spots that @benmccann highlighted? Then I think we can merge this

@kurkle
Copy link
Member Author

kurkle commented Aug 20, 2022

Yes. My laptop gave up, so it will be a couple more days still.

@kurkle kurkle merged commit 1d6b8cc into chartjs:master Aug 23, 2022
@kurkle kurkle deleted the integration-docs branch August 23, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kurkle @etimberg @benmccann @LeeLenaleee @artfulrobot