Convert the easing helpers to typescript #10627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd move the type(s) |
|
Random thought, we could visualize the effects as line charts in the docs |
|
@etimberg Hi. You should add these helpers here https://github.com/chartjs/Chart.js/blob/master/src/helpers/types.ts |
|
Awesome, will try and do that tonight |
etimberg
force-pushed
the
easing-helpers-ts
branch
from
1b33809
to
857acbd
Compare
|
Types moved and exported |
LeeLenaleee
approved these changes
Aug 30, 2022
kurkle
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the easing helpers to TS.
One thing to consider here is where we want to store types like
EasingFunction. I was tempted to move the definition intohelpers.easing.tsand redefine it to betype EasingFunction = keyof effects. If we're good with that change, I can add it on