-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: render multiline legend items without overlapping (#10532) #10641
Merged
etimberg
merged 9 commits into
chartjs:master
from
kartik-madhak:bugfix/10532-vertical-legend-multiline-labels-overlaps
Sep 16, 2022
Merged
FIX: render multiline legend items without overlapping (#10532) #10641
etimberg
merged 9 commits into
chartjs:master
from
kartik-madhak:bugfix/10532-vertical-legend-multiline-labels-overlaps
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nirav Chavda <[email protected]>
Co-authored-by: Nirav Chavda <[email protected]>
kurkle
reviewed
Aug 31, 2022
Co-authored-by: Nirav Chavda <[email protected]>
kurkle
reviewed
Sep 2, 2022
Co-authored-by: kartik <[email protected]>
Co-authored-by: kartik <[email protected]>
etimberg
reviewed
Sep 10, 2022
test/fixtures/plugin.legend/legend-doughnut-right-center-mulitiline-labels.json
Show resolved
Hide resolved
Co-authored-by: Nirav Chavda <[email protected]>
Co-authored-by: Nirav Chavda <[email protected]>
etimberg
previously approved these changes
Sep 12, 2022
Co-authored-by: Nirav Chavda <[email protected]>
kurkle
previously approved these changes
Sep 14, 2022
etimberg
previously approved these changes
Sep 14, 2022
Looks like the size limit needs to be increased slightly to accommodate this change. @kartik-madhak can you up that and then we'll merge this? It's this file https://github.com/chartjs/Chart.js/blob/master/.size-limit.cjs and the failing GH action logs https://github.com/chartjs/Chart.js/blob/master/.size-limit.cjs#L37 should be updated. I think a good new size is "27.5KB" |
LeeLenaleee
previously approved these changes
Sep 15, 2022
niravchavda99
deleted the
bugfix/10532-vertical-legend-multiline-labels-overlaps
branch
September 16, 2022 13:08
kartik-madhak
restored the
bugfix/10532-vertical-legend-multiline-labels-overlaps
branch
September 16, 2022 13:12
Co-authored-by: kartik <[email protected]>
niravchavda99
dismissed stale reviews from LeeLenaleee, etimberg, and kurkle
via
September 16, 2022 13:13
0411441
kurkle
approved these changes
Sep 16, 2022
etimberg
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Nirav Chavda [email protected]
Fixes: this issue
Explanation
Previously all the labels were considered to have a constant height, we changed it so that it calculates the height in case of multi-line labels
Screenshot
Input for the above screenshot: -