Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove default axis override when custom id is given #10643

Merged
merged 7 commits into from
Sep 2, 2022
Merged

feat: remove default axis override when custom id is given #10643

merged 7 commits into from
Sep 2, 2022

Conversation

dangreen
Copy link
Collaborator

Closes #10190

Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration guide needs an update

src/core/core.config.js Outdated Show resolved Hide resolved
docs/migration/v4-migration.md Outdated Show resolved Hide resolved
test/specs/core.scale.tests.js Outdated Show resolved Hide resolved
test/specs/core.scale.tests.js Outdated Show resolved Hide resolved
@dangreen
Copy link
Collaborator Author

@LeeLenaleee

so this example

scales: {
bottom: {
type: 'category',
position: 'bottom'
},
top: {
type: 'category',
position: 'top'
}
}

now should look like

      scales: {
        x: {
          type: 'category',
          position: 'bottom'
        },
        top: {
          type: 'category',
          position: 'top'
        }
      }

is it ok?

@LeeLenaleee
Copy link
Collaborator

Yes

src/core/core.config.js Outdated Show resolved Hide resolved
@dangreen dangreen requested review from kurkle and removed request for LeeLenaleee August 31, 2022 17:03
@kurkle kurkle merged commit 8ff853c into chartjs:master Sep 2, 2022
@dangreen dangreen deleted the feat-disable-axis-override branch September 2, 2022 07:36
@stockiNail stockiNail mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default axis overrride when custom ID is given.
4 participants