Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect aspect ratio with container height #10646

Merged
merged 2 commits into from
Sep 2, 2022
Merged

fix: respect aspect ratio with container height #10646

merged 2 commits into from
Sep 2, 2022

Conversation

dangreen
Copy link
Collaborator

Fixes #9762

@dangreen dangreen changed the title fix: honor aspect ratio with container height fix: respect aspect ratio with container height Aug 31, 2022
@dangreen dangreen marked this pull request as ready for review August 31, 2022 20:55
kurkle
kurkle previously approved these changes Sep 1, 2022
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

etimberg
etimberg previously approved these changes Sep 1, 2022
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Does this need a note in the migration guide?

@kurkle
Copy link
Member

kurkle commented Sep 2, 2022

I think it would be good to mention in the migration guide.

@dangreen dangreen dismissed stale reviews from etimberg and kurkle via 8cbb811 September 2, 2022 09:18
@dangreen
Copy link
Collaborator Author

dangreen commented Sep 2, 2022

@etimberg @kurkle done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maintainAspectRatio aligns to container width only
3 participants