Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use guard clause typings #10683

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Use guard clause typings #10683

merged 2 commits into from
Sep 27, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

Resolves #10681

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Sep 20, 2022
@LeeLenaleee LeeLenaleee added this to the Version 4.0 milestone Sep 20, 2022
@kurkle kurkle merged commit fbaf28e into chartjs:master Sep 27, 2022
@LeeLenaleee LeeLenaleee deleted the use-guard-clause branch September 27, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangreen dangreen dangreen approved these changes

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: enhancement type: types Typescript type changes
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

Change the isXxx function as a type guard function.
4 participants
@LeeLenaleee @dangreen @etimberg @kurkle