Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct area to clip for dataset drawing when stacked scales are used #10691

Merged
merged 7 commits into from
Oct 1, 2022

Conversation

stockiNail
Copy link
Contributor

@stockiNail stockiNail commented Sep 21, 2022

Fix #10686

TODO

  • test cases

@stockiNail stockiNail marked this pull request as ready for review September 21, 2022 21:13
@stockiNail
Copy link
Contributor Author

It's not clear to me how to fix the CI job.

Error creating comment. This can happen for PR's originating from a fork without write permissions.
Error: Size limit has been exceeded.

@LeeLenaleee
Copy link
Collaborator

Seems that this line has to be increased to 77.2 ish so its bit safe for the future:

limit: '77 KB',

Weird that it ran twice in which one time it was over and one time it wasn't.

@LeeLenaleee LeeLenaleee added this to the Version 4.0 milestone Sep 22, 2022
@stockiNail
Copy link
Contributor Author

Seems that this line has to be increased to 77.2 ish so its bit safe for the future:

@LeeLenaleee thank you very much. Do you think I can change that file setting new value?

@LeeLenaleee
Copy link
Collaborator

Yes you can, otherwise CI will keep failing

@stockiNail
Copy link
Contributor Author

Yes you can, otherwise CI will keep failing

Sounds fixed!!! Thank you @LeeLenaleee

src/core/core.controller.js Outdated Show resolved Hide resolved
src/core/core.controller.js Outdated Show resolved Hide resolved
@stockiNail
Copy link
Contributor Author

stockiNail commented Sep 26, 2022

I see the error Error: Size limit has been exceeded.. Maybe is the update of size limit to 77.2 not enough?

PR #10707

@kurkle
Copy link
Member

kurkle commented Sep 26, 2022

  {
    "name": "dist/chart.js",
    "passed": false,
    "size": 77224,
    "sizeLimit": 77200,
    "loading": 1.50828125
  },

@stockiNail
Copy link
Contributor Author

  {
    "name": "dist/chart.js",
    "passed": false,
    "size": 77224,
    "sizeLimit": 77200,
    "loading": 1.50828125
  },

I was having a look the second execution.

@LeeLenaleee
Copy link
Collaborator

LeeLenaleee commented Sep 26, 2022

It was enough as you can see in the first screenshot but now this code contains more bytes compiled as you can see in the second screenshot
image
g
image

EDIT

MB big jump is because of my MR #10702

.size-limit.cjs Outdated Show resolved Hide resolved
@etimberg
Copy link
Member

etimberg commented Oct 1, 2022

@kurkle did you still want to review this?

@kurkle kurkle merged commit c51d697 into chartjs:master Oct 1, 2022
@stockiNail stockiNail deleted the fixStackedScales branch November 7, 2022 15:24
@joshkel joshkel mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line chart with stack mode and max value - overflow
4 participants