Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move batch of helpers to ts #10722

Merged
merged 2 commits into from
Sep 30, 2022
Merged

refactor: move batch of helpers to ts #10722

merged 2 commits into from
Sep 30, 2022

Conversation

dangreen
Copy link
Collaborator

No description provided.

@dangreen dangreen marked this pull request as ready for review September 28, 2022 22:37
etimberg
etimberg reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments

src/helpers/types.ts Outdated Show resolved Hide resolved
src/helpers/helpers.collection.ts Show resolved Hide resolved
@etimberg etimberg added the type: types Typescript type changes label Sep 28, 2022
@etimberg etimberg merged commit d1e118a into chartjs:master Sep 30, 2022
@dangreen dangreen deleted the refactor-ts-helpers branch October 3, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dangreen @etimberg @kurkle