Convert helpers.extra to TS #10728
Merged
Convert helpers.extra to TS #10728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
commented
Sep 30, 2022
| const event = args[0]; | ||
| return [event, event.offsetX, event.offsetY]; | ||
| }); | ||
| }, chart); |
There was a problem hiding this comment.
Initially I had provided some very complex types for throttled so that we could verify the arguments to the callback function. However, this identified that we don't actually use the 2nd and 3rd parameters here so I removed the 3rd argument. That change allowed removal of the updateFn from the helper which is the breaking change
|
Test failure will be fixed in #10729 and then I will rebase this PR |
etimberg
force-pushed
the
helpers-extra
branch
from
cf71ca0
to
ae1c5a7
Compare
LeeLenaleee
reviewed
Sep 30, 2022
| import {_limitValue} from './helpers.math'; | ||
| import {_lookupByKey} from './helpers.collection'; | ||
|
|
||
| export function fontString(pixelSize, fontStyle, fontFamily) { | ||
| export function fontString(pixelSize: number, fontStyle: string, fontFamily: string) { |
There was a problem hiding this comment.
Do we want the fontStyle types as the different types like bold, italic etc?
There was a problem hiding this comment.
We could. Not sure how complicated that might be given all the combinations of styles that could be supplied
etimberg
force-pushed
the
helpers-extra
branch
from
ae1c5a7
to
be3d163
Compare
kurkle
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the
helpers.extrafile to TS. I took the opportunity to simplify thethrottledhelper which is the breaking change