Fix #10749 - backdrops with rotated labels #10759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
reviewed
Oct 6, 2022
Because backdrop now occurs after translation, we don't want to double-adjust the position.
|
@etimberg , @kurkle , I appreciate the feedback - I went back and figured out what was really going on - because I moved the backdrop after the rotation (in order to address the bug), the translation adjustment was being double-counted. With my most recent commit, it simply removes the top/left adjustment, because that's now taken care of in the translation. I'd appreciate another look. Thank you so much for your time!! |
etimberg
approved these changes
Oct 11, 2022
kurkle
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the backdrop work on rotated labels, the backdrop needs to be moved into renderText(). Additionally, the x/y coordinates calculated inside _computeLabelItems() didn't properly account for rotated text, and the most elegant solution turned out to be to just use modern measureText() to determine the x/y of the label.
Although the label backdrop isn't a very used feature, probably, storing the accurate coords inside of the options group opens up a range of possibilities with attaching hover/click events over the axis labels, which are otherwise impossible.