fix: Always draw full arcs and borders for doughnut slices #10806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10801
The root cause was bad behavior when floating-point arithmetic just pushed a single slice into self-overlap territory and
drawFullCircleBorders
does not account for offset likepathArc
does, resulting in borders drawn in the wrong location. This PR updatesdrawBorder
to rely onpathArc
instead, although I suspect further improvements could fully unify everything and draw arcs and borders together.