Fix the missing apply for the color on the legend labels

[stockiNail]

Fix #10854

[LeeLenaleee]

I gave the doughnut controller a quick look, there they override the generate labels and don't set the font color, if we do that I'm pretty sure it also should work and it would be the nicer solution in my oppinion

[stockiNail]

I gave the doughnut controller a quick look, there they override the generate labels and don't set the font color, if we do that I'm pretty sure it also should work and it would be the nicer solution in my oppinion

Ah ok, I understood better now that PR. Therefore we should change the generateLabels adding the font color! Therefore we must change doughnut and polarArea generateLabels in the controllers

[stockiNail]

@LeeLenaleee I have changed PR as you suggested.

EDIT: about CC, the generateLabels functions in polar and doughnut controllers are equals! But it was previously as is as well.

[stockiNail]

@LeeLenaleee there is a side effect. generateLabels is a public API and whoever implement it must apply the color of legend labels otherwise it will be ignored I guess

[LeeLenaleee]

That is true but the same goes for the other options like providing the extra data so the default onClick keeps working.

So I am fine with that

[stockiNail]

Yes but for this use case you have the same situation for pointStyle and only for it and probably the pointStyle case is managed by plugin. I will have a look later before going on, if you agree

[stockiNail]

@LeeLenaleee I had a look and I see that it's working as you correctly reported. Therefore it's fine for me as well. Last remark. I had the feeling this is a breaking change for whom developed own generateLabels callback. Should this PR be tagged as breaking change and report it in the migration guide?

[LeeLenaleee]

I guess you could do it, technically the or you mentioned that introduced this got tagged breaking and put a note in migration guide but that is probably not something people will associate with this.

So many you could extend that migration note and keep this as a bugfix

[stockiNail]

Apologize... I think I'm tired or getting old and I haven't seen the note about fontColor.... 100% with you! Let's stay as is for all! Thank you!

[LeeLenaleee]

Np, np, no need to apologize for those kind of things or invalidating approval because you fixed cc or something else. Those things are part of the job and happen to all of us, makes us human :)

[dargmuesli]

Thank you for the quick and kind fix! ❤️ If you can spend one, a new alpha release would be fancy 🤓