v4.0.0 bump #10868
Merged
v4.0.0 bump #10868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
approved these changes
Nov 12, 2022
|
There is something I need to check first tomorrow. See for this issue, looks like we are breaking a typings issue right now. |
Added that bug to the milestone. We can always move it ahead, if it's not a blocker. |
|
The underlying issue for that issue is not blocking, it picks the wrong ts type, that is not blocking, you can cast it to the correct one. But it would be nice if this bug fix does get merged since it prevents users from creating charts with different types without a main type now: #10869 |
LeeLenaleee
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump for v4 release