Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixes compilation error when option --isolatedModules is set #11095

Merged
merged 2 commits into from
Jan 28, 2023
Merged

🐛 fixes compilation error when option --isolatedModules is set #11095

merged 2 commits into from
Jan 28, 2023

Conversation

jljouannic
Copy link
Contributor

Fixes #11094

Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this until V5 since this will be a breaking change.

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Jan 27, 2023
@jljouannic
Copy link
Contributor Author

jljouannic commented Jan 27, 2023

I guess the beaking change here is the removal of UpdateModeEnum, isn't it?

Instead of removing UpdateModeEnum, I could convert it to a "normal" enum (without const). It would still fix the compilation issue. Would it be considered a breaking change?

@etimberg
Copy link
Member

I guess the beaking change here is the removal of UpdateModeEnum, isn't it?

Instead of removing UpdateModeEnum, I could convert it to a "normal" enum (without const). It would still fix the compilation issue. Would it be considered a breaking change?

I think this would be safe to make

@LeeLenaleee
Copy link
Collaborator

It might still be breaking without const, I know TS will do strange compile things with that. I think @dangreen might be able to answer that better if it will break things since he is more into TS than me

@dangreen
Copy link
Collaborator

@LeeLenaleee @etimberg @jljouannic Hi. For me, it looks like a minor change.

enum -> const enum can look like a breaking change, but we have const enum -> enum, so it is backward compatible.

@etimberg etimberg added this to the Version 4.2.1 milestone Jan 28, 2023
@etimberg etimberg merged commit b967d71 into chartjs:master Jan 28, 2023
@Poky85
Copy link

Poky85 commented Feb 1, 2023

Could we release this soon? 🙏 I'm not able to use the lib in the project with --isolatedModules compile option enabled.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build project using chartjs if TypeScript compiler option isolatedModules is set to true
6 participants