Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip fixes (getLabelAndValue on null controller, null getParsed) #11596

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Tooltip fixes (getLabelAndValue on null controller, null getParsed) #11596

merged 2 commits into from
Nov 29, 2023

Commits on Nov 28, 2023

  1. Fix for getLabelAndValue on null controller 

    I encountered chartjs#11315 under the following circumstances:

1. Position the cursor over the chart area, such that it causes a
   tooltip to be shown.
2. Move the cursor out of the chart area, such that the tooltip remains
   visible.
3. Cause the chart contents to be changed, such that the dataset
   referenced by the active tooltip element is no longer valid.
4. Move the mouse again.  This triggers an `inChartArea = false` event,
   so it reuses the previous, now invalid, active elements.

This fixes chartjs#11315 under the circumstances for which I've reproduced it,
but there may be others.
    @joshkel
    joshkel committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b3a42e3 View commit details
    Browse the repository at this point in the history

  2. Further fixes for elements added / changed 

    This possibly fixes chartjs#11365.
    @joshkel
    joshkel committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    42577a0 View commit details
    Browse the repository at this point in the history