Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font spec type #11605

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

LeeLenaleee
Copy link
Collaborator

Resolves: #11603

Not sure if we see this as breaking 🤔

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Dec 4, 2023
@LeeLenaleee LeeLenaleee added this to the Version 4.4.1 milestone Dec 4, 2023
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it might break things, but also its a bug fix

@LeeLenaleee
Copy link
Collaborator Author

Yeah thought the same, worst case we revert it and wait for next major

@LeeLenaleee LeeLenaleee merged commit 8e19199 into chartjs:master Dec 4, 2023
8 checks passed
@LeeLenaleee LeeLenaleee deleted the update-font-spec-typing branch December 4, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error with font weight as a number
2 participants