-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow styling of line segments #8844
Conversation
Gap styling range styling cache reset Allow styling of line segments
fc19dff
to
93bcb33
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this is going
I really like this PR. Great! |
Needs changes in the filler plugin. I think its better done separately. |
Fully agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already agreed on the 'scriptable' approach on Slack (I didn't look deep in the implementation).
👍 Looking at the docs for the feature I see that I can specify segment overrides as scriptables. Does the feature also support setting a different borderColor per data point within the data array? My use case for this is twofold:
|
Alternative implementation
Closes #7523
Closes #7193
Closes #5956
Closes #4895
Closes #4434
TODO