-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of parsed array changes when parsing===false #9525
Conversation
I think this would remove the performance gains from |
This would have a perf impact, though the items inside the array are not changed, just the outer array itself. We could drop the use of |
Would putting that inside an if be enough? Chart.js/src/core/core.datasetController.js Lines 933 to 935 in bc6ef16
|
I don't think that's right because then changes to the elements would never happen so a single |
The changes would be applied at the end of Chart.js/src/core/core.datasetController.js Lines 950 to 954 in bc6ef16
I did not realize the actual issue is the delayed multiple syncs that are already applied to the |
That solution looks good to me! I will implement that today |
I think you forgot about this :) |
haha I did, will definitely get to it today 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of hoped you'd pick a better name for the helper, but I don't have any suggestions :)
Resolves #9511