fix getRelativePosition type definition #9610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I referred to this official document.
https://www.chartjs.org/docs/latest/configuration/interactions.html#converting-events-to-data-values
The argument of
onClick
function is defined here.Chart.js/types/index.esm.d.ts
Line 1493 in 3792f9d
The
getRelativePosition
supports both types in JS code. The followinggetCanvasPosition
function is called ingetRelativePosition
.Chart.js/src/helpers/helpers.dom.js
Line 63 in bc7c58d
Then, the first argument of
getRelativePosition
should acceptChartEvent
too.