-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add beforeDestroy hook #9933
add beforeDestroy hook #9933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add to documentation.
Thats what I thought but when I looked at the plugins hook section it only showed render diagrams for the inialization, update, render and event prosses. Did I miss a place in the docs where all the hooks get described because I couldnt find it, also not with the search bar? Or do you suggest adding an extra diagram for destroying the chart on that plugin section? |
@LeeLenaleee let me ask you if makes sense to you to change also the |
docs/developers docs/developers/plugin_flowcharts.drawio |
Yeah this does indeed make sense because it happens after the destroy and would be more in line with the current naming of hooks. But like you said this will be a breaking change so best thing to do I think is make a new issue for this to rename it and target v4 with it.
Thanks, means I didnt miss a spot. The uninstall prosess was not being described but I will make a flow for that one and add it 👍 |
We could add the afterDestroy already and leave the destroy hook to be removed in V4. |
That works for me. We can just deprecate the destroy hook but leave it in until v4 |
As user, I'd expect after the deletion from the instances. But this is just my personal opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notify stop
two times in the flow chart
Resolves #9931