Modernize setup.py and versioning #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we are building the C extension any more. I think the JIT work @jchodera has been working on is meant to replace it. In the existing version, it was only ever built in Python 2.X. |
|
Correct, no C extension. I'm the one that is still a bit behind on the jit extension - I had it working in JAX, but not in numba yet. Will be working on that the next couple of days. |
|
The linting errors are for old_mbar.py, which should be deprecated soon (#415), so no need to worry. Merging! |
|
The version looks funny now, but we'll fix that with proper tags for v4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Questions:
Closes #377