Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to using mamba for rtd building #494

Merged
merged 4 commits into from
Mar 15, 2023
Merged

switch to using mamba for rtd building #494

merged 4 commits into from
Mar 15, 2023

Conversation

mikemhenry
Copy link
Contributor

Solves #493

@mikemhenry
Copy link
Contributor Author

I will make the same fix to the LTS branch so we can get docs building on that as well

@codecov
Copy link

codecov bot commented Mar 15, 2023 •
edited
Loading

Codecov Report

Merging #494 (2543a75) into master (4afa420) will decrease coverage by 0.12%.
The diff coverage is n/a.

@mikemhenry
Copy link
Contributor Author

This should be good to go!

@mrshirts mrshirts merged commit 6adba27 into master Mar 15, 2023
@mrshirts mrshirts deleted the fix/read-the-docs-mamba branch March 15, 2023 23:24
ijpulidos
ijpulidos approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The failing tests on windows are unrelated to the changes in this PR, correct? LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijpulidos ijpulidos ijpulidos approved these changes

@mrshirts mrshirts mrshirts approved these changes

@Lnaden Lnaden Awaiting requested review from Lnaden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikemhenry @ijpulidos @mrshirts