plugins.dailymotion: initial VOD support #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| from livestreamer.compat import urlparse | ||
| from livestreamer.exceptions import PluginError | ||
| from livestreamer.compat import urlparse, unquote, urlparse |
|
A couple of minor issues I found and made inline comments for, other than that it look good. 👍 |
|
Thank you for reviewing and teaching me about |
chrippa
added a commit
that referenced
this pull request
May 28, 2014
plugins.dailymotion: Initial VOD support
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Dailymotion VODs, using
SegmentedStream(based on the UStream plugin). It works well in the cases I've tested, (VLC + file output which is seekable), even though I get a lot of[flv @ 0x7f2dccc01c20] Skiping duplicate indexerrors when playing the file. I'm not sure if this is a big issue.
Oops, forgot about Python 3. Will fix that.