plugin.gaminglive: basic support for gaming live #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gaminglive.TV went into open alpha while i was writing the pull-request. This also changed the stream URLs. Hence the second commit. Sorry about that. |
chrippa
added a commit
that referenced
this pull request
Aug 2, 2014
Added plugin for gaminglive.tv.
|
Thanks! PS. You might want to set your text editor to use Unix line endings instead of DOS ones in the future as I believe 99% open source projects use that. ;-) |
|
Thanks for the info. I thought PyCharm defaults to Linux line endings and didn't bother to check. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt to do something beyond "Hello World" in Python.
GamingLive.TV is a new streaming portal which is in a somewhat closed alpha state right now. You can't register as new user and streamers are invited by GamingLive directly.
The plugin supports live-streams only (i believe there are no VODs at the moment). No special parameters or configuration. You just type:
Since it is a new platform there not many streamers at any given time. You can get a list of all live broadcasters with this url:
The code should be straight forward. I don't like the way i handled the JSON response (lots of
if not ... return). I tried to use your schema validation API but i did not understand it enough to make it work.As i said i have close to no experience with Python so any additional comment would be greatly appreciated.
And also this is my first pull-request, if i did anything wrong please let me know.
Thanks.