StatelessVideoDecoder implementations for StatelessDecoder can be factorized?
#77
Comments
Gnurou
added a commit
that referenced
this issue
Jun 16, 2024
These implementations do essentially the same thing, only with a different format change callback, so factorize the common behavior into a single method taking the callback as argument. This has the benefit of performing the state change in a single place, which is less error-prone. Helps with issue #77.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have one implementation per codec, with many methods that are strictly identical. We should be able to factorize this by implementing the methods that differ as regular methods of
StatelessDecoder, and having a singleStatelessVideoDecoderimpl block that calls these.next_eventwould probably require another trait method on the decoder device.The text was updated successfully, but these errors were encountered: