Skip to content

Commit

Permalink
ambr createNodeFromDefinition addNodeFromDefinition
Browse files Browse the repository at this point in the history
  • Loading branch information
xieyuheng committed Nov 15, 2023
1 parent 8caa0dc commit ac9bb54
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 15 deletions.
6 changes: 3 additions & 3 deletions src/lang/check/checkRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { BlockStmt } from "../exp/BlockStmt"
import { refreshNode } from "../freshen/refreshNode"
import { Mod } from "../mod"
import { findDefinitionOrFail } from "../mod/findDefinitionOrFail"
import { createNodeFromDefinition } from "../node/createNodeFromDefinition"
import { addNodeFromDefinition } from "../node/addNodeFromDefinition"
import { RuleTarget } from "../rule"
import { exposeRuleTargets } from "../rule/exposeRuleTargets"
import { checkAllLocalsAreUsed } from "./checkAllLocalsAreUsed"
Expand All @@ -20,14 +20,14 @@ export function checkRule(
const checking = createChecking()
const env = createEnv(mod)

const firstNode = createNodeFromDefinition(
const firstNode = addNodeFromDefinition(
env.net,
findDefinitionOrFail(mod, first.name),
)

refreshNode(env.net, checking.typeVarCounters, firstNode)

const secondNode = createNodeFromDefinition(
const secondNode = addNodeFromDefinition(
env.net,
findDefinitionOrFail(mod, second.name),
)
Expand Down
4 changes: 2 additions & 2 deletions src/lang/evaluate/evaluateDefinition.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Definition } from "../definition"
import { Env } from "../env"
import { createNodeFromDefinition } from "../node/createNodeFromDefinition"
import { addNodeFromDefinition } from "../node/addNodeFromDefinition"
import { Value } from "../value"
import { EvaluateOptions } from "./evaluate"

Expand All @@ -11,7 +11,7 @@ export function evaluateDefinition(
): Value {
switch (definition["@kind"]) {
case "NodeDefinition": {
return createNodeFromDefinition(env.net, definition)
return addNodeFromDefinition(env.net, definition)
}

case "TypeDefinition": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,11 @@ import { Net } from "../net"
import { addNode } from "../net/addNode"
import { Node } from "../node"

export function createNodeFromDefinition(
net: Net,
definition: Definition,
): Node {
export function addNodeFromDefinition(net: Net, definition: Definition): Node {
if (definition["@kind"] !== "NodeDefinition") {
throw new Error(
[
`[createNodeFromDefinition] I expect the definition to be NodeDefinition.`,
`[addNodeFromDefinition] I expect the definition to be NodeDefinition.`,
``,
` definition kind: ${definition["@kind"]}`,
].join("\n"),
Expand Down
4 changes: 2 additions & 2 deletions src/lang/present/presentNode.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { capNodeAllPorts } from "../cap"
import { Mod, findDefinitionOrFail } from "../mod"
import { Net, createNet } from "../net"
import { createNodeFromDefinition } from "../node/createNodeFromDefinition"
import { addNodeFromDefinition } from "../node/addNodeFromDefinition"

export function presentNode(mod: Mod, nodeName: string): Net {
const net = createNet()

const definition = findDefinitionOrFail(mod, nodeName)
const node = createNodeFromDefinition(net, definition)
const node = addNodeFromDefinition(net, definition)
capNodeAllPorts(mod, net, node)

return net
Expand Down
6 changes: 3 additions & 3 deletions src/lang/present/presentRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { deleteNodeEntry } from "../net/deleteNodeEntry"
import { disconnectPort } from "../net/disconnectPort"
import { findPrincipalPort } from "../net/findPrincipalPort"
import { Node } from "../node"
import { createNodeFromDefinition } from "../node/createNodeFromDefinition"
import { addNodeFromDefinition } from "../node/addNodeFromDefinition"
import { exposeRuleTargets } from "../rule/exposeRuleTargets"

export function presentRule(mod: Mod, ruleName: string): [Net, Net] {
Expand All @@ -28,12 +28,12 @@ export function presentRule(mod: Mod, ruleName: string): [Net, Net] {

const [firstName, secondName] = ruleName.split(" ")

const firstNode = createNodeFromDefinition(
const firstNode = addNodeFromDefinition(
env.net,
findDefinitionOrFail(mod, firstName),
)

const secondNode = createNodeFromDefinition(
const secondNode = addNodeFromDefinition(
env.net,
findDefinitionOrFail(mod, secondName),
)
Expand Down

0 comments on commit ac9bb54

Please sign in to comment.