Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmojiOne Area pulls libraries from cdnjs.cloudflare.com #1

Open
clarkwinkelmann opened this issue Jan 30, 2017 · 2 comments
Open

EmojiOne Area pulls libraries from cdnjs.cloudflare.com #1

clarkwinkelmann opened this issue Jan 30, 2017 · 2 comments

Comments

@clarkwinkelmann
Copy link
Owner

This is probably due to the default configuration of the library.

It fetches images at cdnjs.cloudflare.com whereas the base emoji plugin fetches them at cdn.jsdelivr.net.

It also load additional css and js files from cdnjs.cloudflare.com. These files are probably already included in the core and should not be fetched again.
clarkwinkelmann added a commit that referenced this issue Feb 1, 2017
@clarkwinkelmann
Use same CDN as Flarum for images
5314f18 
Solve part of #1
@clarkwinkelmann
Copy link
Owner Author

emojione.min.js is still fetched from cdnjs. It seems this file is not loaded by Flarum core or emoji picker so that's the reason it is loaded.

Emojione Area does not seem to have a way to change the CDN for that action 😠

https://github.com/mervick/emojionearea/blob/master/src/function/loadEmojione.js#L45

@pribbernow-marc
Copy link

yes, would be great to deactivate that part if the option "useInternalCDN" is deactivated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pribbernow-marc @clarkwinkelmann