[Draft] Upgrade to webpack 5 (via latest react scripts) after react scripts rejects #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh183
commented
Jun 4, 2024
| ">0.2%", | ||
| "not dead", | ||
| "not op_mini all", | ||
| "not op_mob >= 1" |
There was a problem hiding this comment.
babel/babel#16171 (comment) - fixing the opera browser issue
|
@harsh183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the issues from #789, I decided that upgrading react scripts to the latest version and then trying to eject to fix the cryptography bug was the move. Though this ended up opening a can of worms.
I resolved a lot of different bugs till I got
yarn testandyarn buildworking, butyarn startstill has a lot of issues. I'm not super convinced upgrading webpack v5 from v4 is worth is with around a dozen breaking changes, so I might just leave this branch as-is for now. I've based the commits on the various major bugs I solved.