ON-2506: allow for $el to be undefined #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$el will be undefined when certain kiln inputs are used outside the overlay. Using kiln inputs outside the overlay is helpful when writing a simple custom interface whose inputs should be familiar to the editor. Ideally the kiln inputs would be generic enough to be used outside the context of kiln, however that is surely a "nice to have" rather than a necessary feature. Specifically the simple-list component caused this issue.
jpope19
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$el will be undefined when certain kiln inputs are used outside
the overlay. Using kiln inputs outside the overlay is helpful
when writing a simple custom interface whose inputs should be
familiar to the editor. Ideally the kiln inputs would be generic
enough to be used outside the context of kiln, however that is
surely a "nice to have" rather than a necessary feature.
Specifically the simple-list component caused this issue.