restores X-Clay-User header value #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-owen
approved these changes
Dec 7, 2020
mattoberle
force-pushed
the
x-clay-user
branch
from
f6d2853
to
4042437
Compare
Somewhere way back in (PR744)[#744] a new header called `X-Clay-User` was added to help audit request activity. A refactor later on wiped out this feature, instead only maintaining references to the functionality through an unused `username` positional argument. This commit restores the `X-Clay-User` header by (safely) pulling it from the global state.
mattoberle
force-pushed
the
x-clay-user
branch
from
4042437
to
537dc70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere way back in #744 a new header called
X-Clay-Userwas added to help audit request activity.A refactor later on wiped out this feature, leaving only references to the functionality through an unused
usernamepositional argument.This commit restores the
X-Clay-Userheader by (safely) pulling it from the global state.