upgrades node-sass, runs tests on 10, 12, and 14 LTS #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattoberle
added
dependencies
mattoberle
force-pushed
the
test-all-lts-versions
branch
from
c3173f1
to
5145ca2
Compare
james-owen
reviewed
Dec 7, 2020
mattoberle
force-pushed
the
test-all-lts-versions
branch
from
5145ca2
to
d553c96
Compare
This commit upgrades node-sass to work with newer node runtimes. It also updates the CircleCI test routine to test all supported LTS versions (build and test).
mattoberle
force-pushed
the
test-all-lts-versions
branch
from
d553c96
to
15cd7b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades node-sass to work with newer node runtimes.
It also updates the CircleCI test routine to test all supported LTS versions (build and test).
The change should ensure that Kiln can be built on any supported runtime.