TbHighCharts, problem with encode options

[TheHett]

Hi, after this fix dc41267

I now understand, how to translate js code to options?

before it was done so

            $this->widget('TbHighCharts', array(
                'options' => array(
                    'tooltip' => array(
                        'formatter' => "js:function() {
                                        return Highcharts.numberFormat(this.y, 0) + ' by ' + this.series.name +'<br/>'+' in '+ this.x;
                                       }",
                    ),
                ),
            ));

now its not work :'(

[hijarian]

Haha, absolutely hilarious. What regressions can appear after seemingly innocent fixes.

Thanks for pointing out this problem, @TheHett obviously options cannot be processed as a JSON because JSON doesn't have a way to store functions. This fix is wrong.

I was going to review TbHighCharts anyway. Maybe someone can give you different answer, but I suppose your only option for now is to use a custom fork in which to revert that commit. Sorry about that, I'll fix this behavior soon.

[TheHett]

ok, we while using old version =)
I not have idea solutions to both problems :-\

[Krinopotam]

The same problem in TbRedactorJs and in any other widget that uses Bootstrap->registerPlugin(...)

    $options = empty($options)
        ? ''
        : json_encode($options);

So, we can pass no callback function to RedactorJs for example.

[hijarian]

OK, thanks for pointing it out, @Krinopotam. Hopefully I will be able to do something with it on this weekend.

[hijarian]

For HighCharts I replaced the CJavaScript::jsonEncode with CJavaScript::encode. I don't know now how to reproduce the issue explained in #345 (the one with zero values in HighCharts).

Anyway, the only proper way to incorporate function definitions inside the HighCharts options is to use the CJavaScriptExpression class.

See the examples at documentation website.

[hijarian]

RedactorJs got the same changes, with same effect. Use CJavaScriptExpression to pass javascript functions to the widget options.