-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TbHighCharts, problem with encode options #696
Comments
Haha, absolutely hilarious. What regressions can appear after seemingly innocent fixes. Thanks for pointing out this problem, @TheHett obviously options cannot be processed as a JSON because JSON doesn't have a way to store functions. This fix is wrong. I was going to review |
ok, we while using old version =) |
The same problem in TbRedactorJs and in any other widget that uses Bootstrap->registerPlugin(...)
So, we can pass no callback function to RedactorJs for example. |
OK, thanks for pointing it out, @Krinopotam. Hopefully I will be able to do something with it on this weekend. |
For HighCharts I replaced the Anyway, the only proper way to incorporate function definitions inside the HighCharts options is to use the CJavaScriptExpression class. See the examples at documentation website. |
RedactorJs got the same changes, with same effect. Use |
Hi, after this fix dc41267
I now understand, how to translate js code to options?
before it was done so
now its not work :'(
The text was updated successfully, but these errors were encountered: