TbSelect2 - multiselect and placeholder lead to empty selection

[bluezed]

I've got this TbSelect2 on a page:

$this->widget(  'bootstrap.widgets.TbSelect2',
                array(  'model' => $model,
                        'attribute' => 'reporter_id',
                        'data' => CHtml::listData(LdapUser::getAllActive(), 'id', 'name'),
                        'htmlOptions' => array('multiple'=>true),
                        'options' => array('placeholder'=>Yii::t('portal', 'reporter'))
                )
            );

When nothing is selected it always looks like this:
http://s19.postimg.org/bnx6z3xer/Tb_Select2.png

There's an empty selection box.

When I either set 'multiple'=>false or remove the 'placeholder' then it looks ok.

I guess it has to do with this in the TbSelect2 class?

$this->addEmptyItemIfPlaceholderDefined();

Any way to get around this!?

[ddenev]

Yes, the problem is that $this->addEmptyItemIfPlaceholderDefined() is called even for multiple selects. The select2 docs say that an empty option should be added only for non-multi-value selects:

"Note that because browsers assume the first option element is selected in non-multi-value select boxes an empty first option element must be provided () for the placeholder to work."

So in order to fix this problem, this:

$this->addEmptyItemIfPlaceholderDefined();

should be replaced with this:

if (empty($this->htmlOptions['multiple'])) {
    $this->addEmptyItemIfPlaceholderDefined();
}

Additionally, the proper way to add an empty option as the first element is (in prependDataWithEmptyItem()):

$this->data = array_reverse($this->data, true);
$this->data[''] = '';
$this->data = array_reverse($this->data, true);

Otherwise the empty option is added to the end and the single-select will still show "undefined".

[bluezed]

Thanks for the help!

I've made the changes in my project and it appears to work correctly now.

Just made a Pull Request too: #719

[digitalcrab]

Hello guys! @drank @bluezed
Thank you for your issue, now it is fixed in master branch and will be included into the next release.