[ext-py][dnspython] Fix Tudoor DoS issue (CVE-2023-29483) #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the dnspython upstream commits 1. rthalley/dnspython@f66e25b Upstream PR: rthalley/dnspython#1044 2. rthalley/dnspython@0ea5ad0 Upstream PR: rthalley/dnspython#1054 Change-Id: I20193e975a05a8206f8beba7e9be17f23594afcd
amitsrivastava
requested review from
wing2fly,
ranade1,
athithyaaselvam and
Harshg999
wing2fly
approved these changes
Jul 22, 2024
| @@ -257,22 +283,45 @@ def receive_udp(sock, destination, expiration=None, | |||
| while 1: | |||
There was a problem hiding this comment.
nit: logic is same (1 vs. True) https://github.com/rthalley/dnspython/blob/f66e25b5f549acf66d1fb6ead13eb3cff7d09af3/dns/query.py#L625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the dnspython upstream commits
rthalley/dnspython@f66e25b Upstream PR: Address DoS via the Tudoor mechanism (CVE-2023-29483) rthalley/dnspython#1044
rthalley/dnspython@0ea5ad0 Upstream PR: The Tudoor fix should not eat valid Truncated exceptions [#1053] rthalley/dnspython#1054