You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on github.com and signed with GitHub’s verified signature.
The key has expired.
Adds a handful of fixes + enhancements to the module @Gowiem (#6)
what
This was a long running branch that I was working on to make this module work with a client project. It includes the following fixes / enhancements:
Fixes an issue with triggers causing a null pointer exception when none passed.
Adds the ability to pass multiple filename triggers for a workspace
Updates context.tf
Adds the ability to pass a terraform_version per workspace
Adds the ability to pass remote_execution_mode to a workspace for workspaces that just need state.
Fixes #4 -- Adds the ability to pass complex types (lists / maps) as vars to a workspace. See issue for full details on this one and variables/main.tf lines 2-8 for the guts of the fix.
Adds the ability to pass vcs_branch to a workspace to override the branch.
why
These fixes / enhancements were made as part of moving over a larger client project with ~12 root modules. I believe they're largely self explanatory, but if not then I'm happy to share more info.
Happy to pull any of these fixes / enhancements to another PR if we want to discuss them individually
If ya'll would like, I can update the example / tests for these new items if / where needed.
Feedback
Root workspaces (the stack file’s workspace) — These feel a bit odd in that they are not currently useful for my project. Still personally working through why they’re necessary. AFAIU, these top level workspaces are created for the stack to trigger changes when top level env vars change. But I find that to be a very rare occurrence on my end, so they then end up creating a bunch of workspaces that are unnecessary and bloat the UI. I would like hear your folks use-case for these and understand what I'm missing here.
Docs — Needs a better README to walk a consumer through the hierarchy. I dug into the src a bunch over an afternoon of hacking on it to figure it out.