Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 16, Webpack 5, Webpack-CLI 4 #10

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Upgrade to Node 16, Webpack 5, Webpack-CLI 4 #10

merged 5 commits into from
Oct 26, 2022

Conversation

Nuru
Copy link
Sponsor

@Nuru Nuru commented Oct 26, 2022

what

  • Upgrade dependencies to Node 16, Webpack 5, Webpack-CLI 4, actions/core 1.10.0, actions/exec 1.1.1, actions/github 5.1.1
  • Remove caching via actions/cache

why

  • All of the above are deprecated. GitHub is threatening to cut off support for Node 12, which is what this module currently uses.
  • Caching was not configured correctly and was causing errors because it was not being used correctly

notes

It is possible that cache for this module could be provided by the actions/cache action, which might also help with caching Python and Node prerequisites. For now, at least, we will not attempt caching within this action.

references

@Nuru Nuru requested a review from goruha October 26, 2022 12:09
@Nuru Nuru marked this pull request as draft October 26, 2022 12:09
@Nuru Nuru added the wip Work in Progress: Not ready for final review or merge label Oct 26, 2022
@Nuru Nuru marked this pull request as ready for review October 26, 2022 22:25
@Nuru Nuru added enhancement New feature or request major Breaking changes (or first stable release) and removed wip Work in Progress: Not ready for final review or merge labels Oct 26, 2022
@Nuru Nuru merged commit 32acf31 into master Oct 26, 2022
@goruha goruha deleted the node-16 branch January 31, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major Breaking changes (or first stable release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants